refactor of ApiExceptions

refactor of ApiExceptions

Closed in r107 and r108

[ttt]

lg, just some minor nits

http://rietku.appspot.com/34001/diff/1007/1008
File actor/views.py (right):

http://rietku.appspot.com/34001/diff/1007/1008#newcode594
Line 594: % (request.user and request.user.nick or '(nobody)', view.nick))
neat

http://rietku.appspot.com/34001/diff/1007/1010
File common/api.py (right):

http://rietku.appspot.com/34001/diff/1007/1010#newcode68
Line 68: 
stray new line?

http://rietku.appspot.com/34001/diff/1007/1010#newcode334
Line 334: % (api_user and api_user.nick or '(nobody)', actor_ref.nick))
We're repeating this "user and user.nick or '(nobody)'" pattern and the error
message. Can we do this in ApiOwnerRequired and similarly in
ApiViewableRequired? We'll just pass the actor and the owned entity name to the
constructor.

http://rietku.appspot.com/34001/diff/1007/1010#newcode539
Line 539: raise exception.ApiException('Invalid code')
while we're here, can we include the code in the message?

http://rietku.appspot.com/34001/diff/1007/1010#newcode544
Line 544: 'That mobile number has already been activated')
similarly the mobile number and the few places below

http://rietku.appspot.com/34001/diff/1007/1010#newcode905
Line 905: raise exception.ApiException("Invalid nick")
and include the bad nick in the message?

[termie]

updated per review

http://rietku.appspot.com/34001/diff/1007/1008
File actor/views.py (right):

http://rietku.appspot.com/34001/diff/1007/1008#newcode594
Line 594: % (request.user and request.user.nick or '(nobody)', view.nick))
On 2009/09/18 00:48:14, ttt wrote:
> neat

Done.

http://rietku.appspot.com/34001/diff/1007/1010
File common/api.py (right):

http://rietku.appspot.com/34001/diff/1007/1010#newcode68
Line 68: 
On 2009/09/18 00:48:14, ttt wrote:
> stray new line?

Done.

http://rietku.appspot.com/34001/diff/1007/1010#newcode334
Line 334: % (api_user and api_user.nick or '(nobody)', actor_ref.nick))
On 2009/09/18 00:48:14, ttt wrote:
> We're repeating this "user and user.nick or '(nobody)'" pattern and the error
> message. Can we do this in ApiOwnerRequired and similarly in
> ApiViewableRequired? We'll just pass the actor and the owned entity name to
the
> constructor.

Yeah, I considered it but it seemed to digress from the other exceptions quite a
bit so I was hoping to leave everything with the same interface until it seems
worth the readability changes (right now everything just takes a message and you
never have to keep track of which arguments should be sent or look somewhere
else to find out what the error message will be)

http://rietku.appspot.com/34001/diff/1007/1010#newcode539
Line 539: raise exception.ApiException('Invalid code')
On 2009/09/18 00:48:14, ttt wrote:
> while we're here, can we include the code in the message?

Done.

http://rietku.appspot.com/34001/diff/1007/1010#newcode544
Line 544: 'That mobile number has already been activated')
On 2009/09/18 00:48:14, ttt wrote:
> similarly the mobile number and the few places below

Done.

http://rietku.appspot.com/34001/diff/1007/1010#newcode905
Line 905: raise exception.ApiException("Invalid nick")
On 2009/09/18 00:48:14, ttt wrote:
> and include the bad nick in the message?

Added though I have the feeling this could never be hit (I think clean will
through an exception first)