Issue 47: Email substitutions are not working....

Issue 47: Email substitutions are not working.

The templates for email were designed to be expanded with RequestContext()
so {{SITE_NAME}}, etc. would be available through the processors defined in
common/context_processors.py. However, the templates are instead expanded by
Context() since, I assume, the email functions are not always called from
views that could pass on an HttpRequest object.

I added the local variables needed for template substitution. I changed some
of the subject headings and templates to pass on users' full names more
concistently. I also capitalized full names and nicks where appropriate.

Lastly, I removed trailing spaces so the diff unfortunately shows some
additional changes due to whitespace.

Patch by: Jonas Nockert

[lemonad]

http://rietku.appspot.com/27/diff/1/2
File common/mail.py (right):

http://rietku.appspot.com/27/diff/1/2#newcode147
Line 147: subject = '%s invited you to %s' % (full_name.capitalize(),
I'll remove capitalize(). It didn't work quite as I had figured. Title() could
be an alternative but would not work in all cases either.

http://rietku.appspot.com/27/diff/1/2#newcode163
Line 163: subject = '%s (%s) now follows you' % (full_name.capitalize(),
I'll remove capitalize() (see above).

http://rietku.appspot.com/27/diff/1/2#newcode179
Line 179: subject = '%s (%s) is now following you, too' %
(full_name.capitalize(),
I'll remove capitalize() (see above).

[termie]

Apologies for the untimeliness of my reply.

The SITE_NAME addition is great, but the usage of full name is generally
inconsistent with the rest of the site, name generally having a back seat to
nick, so I'd prefer those sections reverted.

http://rietku.appspot.com/27/diff/1003/1004
File common/mail.py (right):

http://rietku.appspot.com/27/diff/1003/1004#newcode108
Line 108: from_full_name = _full_name(actor_from_ref)
the reason for not having full name is largely because names are not actually
required and are not present in many cases, additionally in the past it has been
confusing for users to see a new contact's full name in the email and then be
taken to a page that more prominently lists their nick. In almost all places on
the site we use nick as the identifier so it felt most appropriate to use that
in the email.

http://rietku.appspot.com/27/diff/1003/1004#newcode147
Line 147: subject = '%s invited you to %s' % (full_name[0].upper() +
full_name[1:],
i'd stick with nick_name here as well

http://rietku.appspot.com/27/diff/1003/1004#newcode163
Line 163: subject = '%s (%s) now follows you' % (full_name[0].upper() +
full_name[1:],
and here, ditching the full name altogether

http://rietku.appspot.com/27/diff/1003/1004#newcode179
Line 179: subject = '%s (%s) is now following you, too' % (full_name[0].upper()
+ \
here too

[lemonad]

I've reworked the patch now and hopefully it's looking a bit better than before.
I got rid of all the full names as you suggested. The only place I'm a little
bit dubious about removing it is in the invite template where it might actually
serve a purpose.