JaikuEngine Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Patch 16003: Updated the xmlrpc interface to conform to OAuth spec (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 3 weeks ago by ttt
Modified:
5 months, 1 week ago
Reviewers:
termie, lemonad
CC:
jaikuengine-reviews_googlegroups.com
SVN Base:
http://jaikuengine.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Updated the xmlrpc interface to include all parameters in the OAuth signature
base string. Currently it only uses oauth parameters, which is not what the spec
says.

Updated documentation to reflect this change.

Patch Set 1

Patch Set 2 : ''

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M api/tests.py View 1 4 chunks 51 lines 0 comments Download
M api/xmlrpc.py View 1 chunk 26 lines 0 comments Download
M doc/request_xmlrpc.txt View 1 chunk 28 lines 0 comments Download

Messages

Total messages: 5
ttt
8 months, 3 weeks ago
lemonad
LGTM (looked at changes, applied patch, and ran the tests).
8 months, 3 weeks ago
termie
On 2009/05/22 17:03:49, lemonad wrote: > LGTM (looked at changes, applied patch, and ran the ...
8 months, 3 weeks ago
lemonad
@voxpelli brought up what seems to be a valid question here: http://www.jaiku.com/channel/jaikuengine/presence/e4958c380acc447494e1fe9bfb05645c#c-ceac23f60a194e54add5f866064e655e Probably speaking out ...
8 months, 3 weeks ago
lemonad
8 months, 3 weeks ago
On 2009/05/22 18:32:54, lemonad wrote:
> @voxpelli brought up what seems to be a valid question here:
>
http://www.jaiku.com/channel/jaikuengine/presence/e4958c380acc447494e1fe9bfb0...
> 
> Probably speaking out of ignorance here, can we use a nonce for xml-rpc as we
> are for the rest interface?

As suspected; I was speaking out of ignorance. I'm assuming a nonce will be part
of the xml-rpc parameters if the API call needs one.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Patches | This issue
This is Rietveld r