Patch 13001: Attempts at fixing issue 73 and issue 63, deals with mixed case user nicks...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Enter> :	respond to / edit current comment

	Patch
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Patch List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Patch 13001: Attempts at fixing issue 73 and issue 63, deals with mixed case user nicks... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 1 month ago by termie

Modified:
3 years, 8 months ago

Reviewers:
adewale

CC:
jaikuengine-reviews_googlegroups.com

SVN Base:
http://jaikuengine.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Attempts at fixing issue 73 and issue 63, deals with mixed case user nicks
Also fixes some other unreported issues:
  - Prevents any access to settings for actors not owned by you
  - When changing passwords you are no longer logged out

Committed: http://code.google.com/p/jaikuengine/source/detail?r=65

Patch Set 1

Total comments: 1

Created: 4 years, 1 month ago

Download raw patch set

	Unified diffs	Side-by-side diffs	Stats			Patch
M	actor/tests.py	View	2 chunks	49 lines	0 comments	Download
M	actor/views.py	View	5 chunks	55 lines	0 comments	Download
M	common/api.py	View	2 chunks	29 lines	0 comments	Download
M	common/fixtures/actors.json	View	1 chunk	24 lines	0 comments	Download
M	common/fixtures/contacts.json	View	2 chunks	39 lines	0 comments	Download
M	common/fixtures/emails.json	View	1 chunk	18 lines	0 comments	Download
M	common/test/base.py	View	1 chunk	33 lines	0 comments	Download
M	login/tests.py	View	1 chunk	30 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

adewale

http://rietku.appspot.com/13001/diff/1/2 File login/tests.py (right): http://rietku.appspot.com/13001/diff/1/2#newcode265 Line 265: #def test_mixed_case(self): Why is this new test commented ...

4 years ago

http://rietku.appspot.com/13001/diff/1/2
File login/tests.py (right):

http://rietku.appspot.com/13001/diff/1/2#newcode265
Line 265: #def test_mixed_case(self):
Why is this new test commented out?

Expand All Messages | Collapse All Messages