JaikuEngine Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Patch 13001: Attempts at fixing issue 73 and issue 63, deals with mixed case user nicks... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 3 months ago by termie
Modified:
4 years, 11 months ago
Reviewers:
adewale
CC:
jaikuengine-reviews_googlegroups.com
SVN Base:
http://jaikuengine.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Attempts at fixing issue 73 and issue 63, deals with mixed case user nicks
Also fixes some other unreported issues:
  - Prevents any access to settings for actors not owned by you
  - When changing passwords you are no longer logged out

Committed: http://code.google.com/p/jaikuengine/source/detail?r=65

Patch Set 1

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M actor/tests.py View 2 chunks 49 lines 0 comments Download
M actor/views.py View 5 chunks 55 lines 0 comments Download
M common/api.py View 2 chunks 29 lines 0 comments Download
M common/fixtures/actors.json View 1 chunk 24 lines 0 comments Download
M common/fixtures/contacts.json View 2 chunks 39 lines 0 comments Download
M common/fixtures/emails.json View 1 chunk 18 lines 0 comments Download
M common/test/base.py View 1 chunk 33 lines 0 comments Download
M login/tests.py View 1 chunk 30 lines 1 comment Download

Messages

Total messages: 2
termie
i suppose I'll LGTM this so I can push the fix
5 years, 3 months ago
adewale
5 years, 3 months ago
http://rietku.appspot.com/13001/diff/1/2
File login/tests.py (right):

http://rietku.appspot.com/13001/diff/1/2#newcode265
Line 265: #def test_mixed_case(self):
Why is this new test commented out?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Patches | This issue
This is Rietveld r